Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: base/base.gyp

Issue 16770006: Implement basic stack traces on Android and reenable unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/debug/stack_trace_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 78f16903ba8582813c698b5a8015d73d32e27e10..3e4f9964bc75aa1a3b366bf4281c1ea61dd32d99 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -132,7 +132,6 @@
],
'dependencies': [
'base_jni_headers',
- 'symbolize',
'../third_party/ashmem/ashmem.gyp:ashmem',
],
'include_dirs': [
@@ -143,9 +142,6 @@
'-llog',
],
},
- 'defines': [
- 'USE_SYMBOLIZE',
- ],
'sources!': [
'debug/stack_trace_posix.cc',
],
@@ -668,7 +664,7 @@
'module_dir': 'base'
},
'conditions': [
- ['use_glib==1 or (OS == "android" and _toolset == "target")', {
+ ['use_glib==1', {
'defines': [
'USE_SYMBOLIZE',
],
@@ -684,10 +680,6 @@
],
}],
],
- 'sources!': [
- # Broken on Android, and already disabled there.
- 'debug/stack_trace_unittest.cc',
- ],
}],
['OS == "ios" and _toolset != "host"', {
'sources/': [
« no previous file with comments | « no previous file | base/debug/stack_trace_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698