Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: chrome/browser/about_flags_unittest.cc

Issue 16770002: Restart Chrome if per session flags have been specified on ChromeOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to ToT and addressed Nico's comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags_unittest.cc
diff --git a/chrome/browser/about_flags_unittest.cc b/chrome/browser/about_flags_unittest.cc
index 0c94f4505a5c194282b0103f04bd415961168b57..34219c3f1d01c94c0a858e639d19bf75e86d3314 100644
--- a/chrome/browser/about_flags_unittest.cc
+++ b/chrome/browser/about_flags_unittest.cc
@@ -223,6 +223,34 @@ TEST_F(AboutFlagsTest, ConvertFlagsToSwitches) {
EXPECT_TRUE(command_line.HasSwitch(kSwitch1));
}
+TEST_F(AboutFlagsTest, CompareSwitchesToCurrentCommandLine) {
+ SetExperimentEnabled(&flags_storage_, kFlags1, true);
+
+ CommandLine command_line(CommandLine::NO_PROGRAM);
+ command_line.AppendSwitch("foo");
+
+ CommandLine new_command_line(CommandLine::NO_PROGRAM);
+ ConvertFlagsToSwitches(&flags_storage_, &new_command_line);
+
+ EXPECT_FALSE(AreSwitchesIdenticalToCurrentCommandLine(new_command_line,
+ command_line));
+
+ ConvertFlagsToSwitches(&flags_storage_, &command_line);
+
+ EXPECT_TRUE(AreSwitchesIdenticalToCurrentCommandLine(new_command_line,
+ command_line));
+
+ // Now both have flags but different.
+ SetExperimentEnabled(&flags_storage_, kFlags1, false);
+ SetExperimentEnabled(&flags_storage_, kFlags2, true);
+
+ CommandLine another_command_line(CommandLine::NO_PROGRAM);
+ ConvertFlagsToSwitches(&flags_storage_, &another_command_line);
+
+ EXPECT_FALSE(AreSwitchesIdenticalToCurrentCommandLine(new_command_line,
+ another_command_line));
+}
+
TEST_F(AboutFlagsTest, RemoveFlagSwitches) {
std::map<std::string, CommandLine::StringType> switch_list;
switch_list[kSwitch1] = CommandLine::StringType();

Powered by Google App Engine
This is Rietveld 408576698