Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2453)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 167683002: Simplify type argument instantiation cache lookup by introducing an array (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 32709)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -2186,13 +2186,11 @@
// generated code size.
__ LoadObject(EDI, type_arguments());
__ movl(EDI, FieldAddress(EDI, TypeArguments::instantiations_offset()));
- __ movl(EBX, FieldAddress(EDI, Array::length_offset()));
__ leal(EDI, FieldAddress(EDI, Array::data_offset()));
- __ leal(EBX, Address(EDI, EBX, TIMES_2, 0)); // EBX is smi.
+ // The instantiations cache is initialized with Object::zero_array() and is
+ // therefore guaranteed to contain kNoInstantiator. No length check needed.
Label loop, found, slow_case;
__ Bind(&loop);
- __ cmpl(EDI, EBX);
- __ j(ABOVE_EQUAL, &slow_case);
__ movl(EDX, Address(EDI, 0 * kWordSize)); // Cached instantiator.
__ cmpl(EDX, EAX);
__ j(EQUAL, &found, Assembler::kNearJump);

Powered by Google App Engine
This is Rietveld 408576698