Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: courgette/disassembler_win32_x64_unittest.cc

Issue 1676683002: [Courgette] Clean up Disassembler; fix ELF Memory leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wrap #include <iostream> under #if COURGETTE_HISTOGRAM_TARGETS. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/disassembler_win32_x64.cc ('k') | courgette/disassembler_win32_x86.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler_win32_x64_unittest.cc
diff --git a/courgette/disassembler_win32_x64_unittest.cc b/courgette/disassembler_win32_x64_unittest.cc
index 8f732b3d746966aedc7c2c54a16b538f164ca741..1121c1054e4617e792c139688163cf7a46a0cb0b 100644
--- a/courgette/disassembler_win32_x64_unittest.cc
+++ b/courgette/disassembler_win32_x64_unittest.cc
@@ -6,6 +6,9 @@
#include <stdint.h>
+#include <string>
+#include <vector>
+
#include "base/memory/scoped_ptr.h"
#include "base/stl_util.h"
#include "courgette/base_test_unittest.h"
@@ -37,16 +40,16 @@ void DisassemblerWin32X64Test::TestExe() const {
disassembler->RVAToSection(0x00401234 - 0x00400000)),
std::string(".text"));
- EXPECT_EQ(0, disassembler->RVAToFileOffset(0));
- EXPECT_EQ(1024, disassembler->RVAToFileOffset(4096));
- EXPECT_EQ(46928, disassembler->RVAToFileOffset(50000));
+ EXPECT_EQ(0U, disassembler->RVAToFileOffset(0));
+ EXPECT_EQ(1024U, disassembler->RVAToFileOffset(4096));
+ EXPECT_EQ(46928U, disassembler->RVAToFileOffset(50000));
std::vector<courgette::RVA> relocs;
bool can_parse_relocs = disassembler->ParseRelocs(&relocs);
EXPECT_TRUE(can_parse_relocs);
EXPECT_TRUE(base::STLIsSorted(relocs));
- const uint8_t* offset_p = disassembler->OffsetToPointer(0);
+ const uint8_t* offset_p = disassembler->FileOffsetToPointer(0);
EXPECT_EQ(reinterpret_cast<const void*>(file1.c_str()),
reinterpret_cast<const void*>(offset_p));
EXPECT_EQ('M', offset_p[0]);
« no previous file with comments | « courgette/disassembler_win32_x64.cc ('k') | courgette/disassembler_win32_x86.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698