Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16757004: Use a direct include of strings headers in ui/, part 3. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jonathan.backer, Ian Vollick, tfarina, ben+watch_chromium.org, penghuang+watch_chromium.org, dcheng, nona+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, James Su
Visibility:
Public.

Description

Use a direct include of strings headers in ui/, part 3. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -104 lines) Patch
M ui/compositor/compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/codec/png_codec.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/display.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/font.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/font_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/insets.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/insets_f.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/pango_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point3_f.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point_f.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/quad_f.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/rect.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/button_drag_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/blue_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/checkbox.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/radio_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/text_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/native_menu_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/message_box_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/bitmap_scroll_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/styled_label.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/styled_label.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/test_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_views_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_views_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view_selector.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/native_cursor_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/checkbox_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/combobox_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/example_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/radio_button_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/scroll_view_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/slider_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/table_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/textfield_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/ime/input_method_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_text_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_private.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/window/dialog_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/web_dialog_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/web_dialog_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/jstemplate_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/web_ui_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16757004/1
7 years, 6 months ago (2013-06-10 23:14:31 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 13:54:34 UTC) #2
Message was sent while issue was closed. 
Change committed as 205537

Powered by Google App Engine
This is Rietveld 408576698