Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: trunk/src/chrome/browser/extensions/activity_log/activity_database_unittest.cc

Issue 16756004: Revert 205059 "We were seeing ActivityLog memory leaks and assor..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/activity_log/activity_database_unittest.cc
===================================================================
--- trunk/src/chrome/browser/extensions/activity_log/activity_database_unittest.cc (revision 205306)
+++ trunk/src/chrome/browser/extensions/activity_log/activity_database_unittest.cc (working copy)
@@ -77,7 +77,7 @@
ActivityDatabase* activity_db = new ActivityDatabase();
activity_db->Init(db_file);
- ASSERT_TRUE(activity_db->is_db_valid());
+ ASSERT_TRUE(activity_db->initialized());
activity_db->Close();
sql::Connection db;
@@ -99,7 +99,7 @@
ActivityDatabase* activity_db = new ActivityDatabase();
activity_db->Init(db_file);
activity_db->SetBatchModeForTesting(false);
- ASSERT_TRUE(activity_db->is_db_valid());
+ ASSERT_TRUE(activity_db->initialized());
scoped_refptr<APIAction> action = new APIAction(
"punky",
base::Time::Now(),
@@ -134,7 +134,7 @@
ActivityDatabase* activity_db = new ActivityDatabase();
activity_db->Init(db_file);
- ASSERT_TRUE(activity_db->is_db_valid());
+ ASSERT_TRUE(activity_db->initialized());
scoped_refptr<BlockedAction> action = new BlockedAction(
"punky",
base::Time::Now(),
@@ -177,7 +177,7 @@
// Record some actions
ActivityDatabase* activity_db = new ActivityDatabase();
activity_db->Init(db_file);
- ASSERT_TRUE(activity_db->is_db_valid());
+ ASSERT_TRUE(activity_db->initialized());
scoped_refptr<APIAction> api_action = new APIAction(
"punky",
mock_clock.Now() - base::TimeDelta::FromMinutes(40),
@@ -237,7 +237,7 @@
// Record some actions
ActivityDatabase* activity_db = new ActivityDatabase();
activity_db->Init(db_file);
- ASSERT_TRUE(activity_db->is_db_valid());
+ ASSERT_TRUE(activity_db->initialized());
scoped_refptr<APIAction> api_action = new APIAction(
"punky",
mock_clock.Now() - base::TimeDelta::FromDays(3)
@@ -309,7 +309,7 @@
activity_db->Init(db_file);
activity_db->SetBatchModeForTesting(false);
activity_db->SetClockForTesting(&mock_clock);
- ASSERT_TRUE(activity_db->is_db_valid());
+ ASSERT_TRUE(activity_db->initialized());
scoped_refptr<APIAction> api_action = new APIAction(
"punky",
mock_clock.Now() - base::TimeDelta::FromMinutes(40),
@@ -343,7 +343,7 @@
activity_db->Init(db_file);
activity_db->SetBatchModeForTesting(true);
activity_db->SetClockForTesting(&mock_clock);
- ASSERT_TRUE(activity_db->is_db_valid());
+ ASSERT_TRUE(activity_db->initialized());
scoped_refptr<APIAction> api_action = new APIAction(
"punky",
mock_clock.Now() - base::TimeDelta::FromMinutes(40),
@@ -388,5 +388,5 @@
activity_db->Close();
}
-} // namespace extensions
+} // namespace

Powered by Google App Engine
This is Rietveld 408576698