Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16756003: Use a direct include of strings headers in content/renderer and content/shell. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, ahutter, dcheng, yurys, Albert Bodenhamer, Ilya Sherman, extensions-reviews_chromium.org, vsevik, benquan, jam, dbeam+watch-autofill_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, chromium-apps-reviews_chromium.org, feature-media-reviews_chromium.org, Raman Kakilate, rouslan+autofillwatch_chromium.org, sail+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Use a direct include of strings headers in content/renderer and content/shell. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -67 lines) Patch
M content/renderer/accessibility/accessibility_node_serializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/android/address_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/phone_number_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/date_time_formatter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_automation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_storage/dom_storage_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/hyphenator/hyphenator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/hyphenator/hyphenator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_center.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_media_constraints.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/memory_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/notification_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/port_allocator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/password_form_conversion_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/content_renderer_pepper_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_clipboard_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_date_time_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/savable_resources.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/stats_collection_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_javascript_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_javascript_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_login_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_login_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/webkit_test_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16756003/1
7 years, 6 months ago (2013-06-10 21:07:29 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160821
7 years, 6 months ago (2013-06-11 02:28:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16756003/1
7 years, 6 months ago (2013-06-11 03:38:30 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 07:17:10 UTC) #4
Message was sent while issue was closed. 
Change committed as 205451

Powered by Google App Engine
This is Rietveld 408576698