Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 16750002: Remove the non-separable blur because it is no longer used. (Closed)

Created:
7 years, 6 months ago by arbesfeld
Modified:
7 years, 6 months ago
Reviewers:
Stephen White, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove the non-separable blur because it is no longer used. Committed: http://code.google.com/p/skia/source/detail?r=9503

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -573 lines) Patch
M bench/BlurRectBench.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gm/blurrect.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMask.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/effects/SkBlurMask.cpp View 1 4 chunks +29 lines, -557 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
arbesfeld
PTAL
7 years, 6 months ago (2013-06-10 19:45:01 UTC) #1
reed1
change seems fine. why did the trybots fail?
7 years, 6 months ago (2013-06-10 19:50:42 UTC) #2
Stephen White
On 2013/06/10 19:50:42, reed1 wrote: > change seems fine. why did the trybots fail? My ...
7 years, 6 months ago (2013-06-10 19:51:45 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-06-11 15:12:40 UTC) #4
Stephen White
LGTM
7 years, 6 months ago (2013-06-11 15:13:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/arbesfeld@chromium.org/16750002/22001
7 years, 6 months ago (2013-06-11 15:13:19 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 15:23:44 UTC) #7
Message was sent while issue was closed.
Change committed as 9503

Powered by Google App Engine
This is Rietveld 408576698