Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16746002: Use a direct include of strings headers in chrome/auto*/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, Raman Kakilate, estade+watch_chromium.org, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, robertshield, Dane Wallinga, dyu1, Albert Bodenhamer, chromium-apps-reviews_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/auto*/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -49 lines) Patch
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_classifier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/contact_provider_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/contact_provider_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/url_prefix.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/url_prefix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/form_structure_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_event_observers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16746002/1
7 years, 6 months ago (2013-06-10 15:09:40 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=136391
7 years, 6 months ago (2013-06-10 17:00:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16746002/1
7 years, 6 months ago (2013-06-10 17:13:16 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 19:54:48 UTC) #4
Message was sent while issue was closed. 
Change committed as 205281

Powered by Google App Engine
This is Rietveld 408576698