DevTools: Move CSS.CSSMedia construction into InspectorCSSAgent

DevTools: Move CSS.CSSMedia construction into InspectorCSSAgent

This preliminary patch prepares for building CSSMedia objects based
on their corresponding InspectorStyleSheets, which would be impossible
without this move.

R=yurys@chromium.org
BUG=247681
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152425

[yurys, 2013-06-13 13:52:05]

https://codereview.chromium.org/16745003/diff/3001/Source/core/inspector/Insp...
File Source/core/inspector/InspectorCSSAgent.cpp (left):

https://codereview.chromium.org/16745003/diff/3001/Source/core/inspector/Insp...
Source/core/inspector/InspectorCSSAgent.cpp:1235:
RefPtr<InspectorStyleSheetForInlineStyle> inspectorStyleSheet =
InspectorStyleSheetForInlineStyle::create(m_domAgent->pageAgent(),
newStyleSheetId, element, TypeBuilder::CSS::StyleSheetOrigin::Regular, this);
I think we should try to get rid of InspectorStyleSheetForInlineStyle ->
InspectorCSSAgent dependency (which is actually dependency on PageAgent). It
used for error reporting and to translate url both of which I think can be
implemented on the caller side, wdyt?

[yurys, 2013-06-13 14:48:35]

https://codereview.chromium.org/16745003/diff/3001/Source/core/inspector/Insp...
File Source/core/inspector/InspectorCSSAgent.h (right):

https://codereview.chromium.org/16745003/diff/3001/Source/core/inspector/Insp...
Source/core/inspector/InspectorCSSAgent.h:145: InspectorPageAgent* pageAgent()
const { return m_pageAgent; }
As discussed offline please revert this part of the change that exposes
pageAgent and the CL looks good to me.

[apavlov, 2013-06-13 16:00:33]

On 2013/06/13 14:48:35, Yury Semikhatsky wrote:
>
https://codereview.chromium.org/16745003/diff/3001/Source/core/inspector/Insp...
> File Source/core/inspector/InspectorCSSAgent.h (right):
> 
>
https://codereview.chromium.org/16745003/diff/3001/Source/core/inspector/Insp...
> Source/core/inspector/InspectorCSSAgent.h:145: InspectorPageAgent* pageAgent()
> const { return m_pageAgent; }
> As discussed offline please revert this part of the change that exposes
> pageAgent and the CL looks good to me.

Done. Please take another look.

[yurys, 2013-06-13 17:02:16]

lgtm

[commit-bot: I haz the power, 2013-06-14 06:10:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apavlov@chromium.org/16745003/10001

[commit-bot: I haz the power, 2013-06-14 07:33:23]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[apavlov, 2013-06-14 07:45:01]

Committed patchset #3 manually as r152425 (presubmit successful).