Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16742003: Use a direct include of strings headers in chrome/browser/a*-c*/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, markusheintz_, sail+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/browser/a*-c*/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M chrome/browser/about_flags.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/crash_dump_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/intent_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/auto_launch_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/local_data_container.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/certificate_manager_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/character_encoding.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/character_encoding.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_process_finder_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_security_exploit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_to_mobile_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_configurator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/crash_handler_host_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/crash_upload_list_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16742003/1
7 years, 6 months ago (2013-06-10 16:03:52 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160516
7 years, 6 months ago (2013-06-10 19:36:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16742003/1
7 years, 6 months ago (2013-06-10 19:40:37 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 22:53:53 UTC) #4
Message was sent while issue was closed. 
Change committed as 205335

Powered by Google App Engine
This is Rietveld 408576698