Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16739011: Use a direct include of strings headers in chromeos/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in chromeos/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M chromeos/app_mode/kiosk_oem_manifest_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/audio/audio_device.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/audio/audio_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/cryptohome/cryptohome_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/audio_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/cros_disks_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_session_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/gsm_sms_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_engine_factory_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/ibus/ibus_property_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_policy_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/power_supply_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/session_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/sms_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/update_engine_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/volume_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/disks/disk_mount_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/disks/mock_disk_mount_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/display/output_configurator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/display/output_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/ime/component_extension_ime_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/ime/extension_ime_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/ime/ibus_daemon_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/ime/input_method_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/ime/xkeyboard.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/device_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/geolocation_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/geolocation_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_change_notifier_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_event_log.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_event_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_event_log_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_profile_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_certificate_importer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_validator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/shill_property_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/system/name_value_pairs_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16739011/1
7 years, 6 months ago (2013-06-10 20:22:47 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160871
7 years, 6 months ago (2013-06-11 03:27:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16739011/1
7 years, 6 months ago (2013-06-11 03:36:01 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 06:32:53 UTC) #4
Message was sent while issue was closed. 
Change committed as 205437

Powered by Google App Engine
This is Rietveld 408576698