third_party/WebKit/Source/core/dom/IntersectionObserver.h - Issue 1672273002: Enforce containing block requirement for IntersectionObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.h

Issue 1672273002: Enforce containing block requirement for IntersectionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObservation.cpp ('k') | third_party/WebKit/Source/core/dom/IntersectionObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObserver.h

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.h b/third_party/WebKit/Source/core/dom/IntersectionObserver.h

index 067dba5257faec88e2bf47741c233d00529fe4fe..6003f565b578ae73541546a0c3a6a3dbb96dc909 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.h

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.h

@@ -43,13 +43,11 @@ public:

const Length& rightMargin() const { return m_rightMargin; }

const Length& bottomMargin() const { return m_bottomMargin; }

const Length& leftMargin() const { return m_leftMargin; }

- bool isDescendantOfRoot(const Element*) const;

void computeIntersectionObservations();

void enqueueIntersectionObserverEntry(IntersectionObserverEntry&);

void applyRootMargin(LayoutRect&) const;

unsigned firstThresholdGreaterThan(float ratio) const;

void deliver();

- void setActive(bool);

void disconnect();

void removeObservation(IntersectionObservation&);

bool hasEntries() const { return m_entries.size(); }