third_party/WebKit/Source/core/dom/IntersectionObservation.h - Issue 1672273002: Enforce containing block requirement for IntersectionObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.h

Issue 1672273002: Enforce containing block requirement for IntersectionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/iframe-root-expected.txt ('k') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObservation.h

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.h b/third_party/WebKit/Source/core/dom/IntersectionObservation.h

index d8e69ef09417e9662ecf53708ae47042acabf789..5df531f4b85acc1b80e1adb222bdca06df8f8d1f 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.h

+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.h

@@ -28,8 +28,6 @@ public:

IntersectionObserver& observer() const { return *m_observer; }

Element* target() const;

- bool isActive() const { return m_active; }

- void setActive(bool active) { m_active = active; }

unsigned lastThresholdIndex() const { return m_lastThresholdIndex; }

void setLastThresholdIndex(unsigned index) { m_lastThresholdIndex = index; }

bool shouldReportRootBounds() const { return m_shouldReportRootBounds; }

@@ -52,7 +50,6 @@ private:

// this can be changed to WeakMember<Element>.

WeakPtrWillBeWeakMember<Node> m_target;

- unsigned m_active : 1;

unsigned m_shouldReportRootBounds : 1;

unsigned m_lastThresholdIndex : 30;

};