Refactor WebCore::DragImage.

Source/WebKit/chromium/src/DragClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "DragClientImpl.h"
 #include "WebViewClient.h"
 #include "WebViewImpl.h"
 #include "core/page/Frame.h"
+#include "core/platform/DragImage.h"
 #include "core/platform/chromium/ChromiumDataObject.h"
 #include "core/platform/chromium/ClipboardChromium.h"
-#include "core/platform/chromium/DragImageRef.h"
+#include "core/platform/graphics/IntSize.h"
 #include "core/platform/graphics/skia/NativeImageSkia.h"
 #include "public/platform/WebCommon.h"
 #include "public/platform/WebDragData.h"
 #include "public/platform/WebImage.h"
+#include "public/platform/WebPoint.h"
+#include "public/web/WebDragOperation.h"
+#include "wtf/Assertions.h"
+#include "wtf/RefPtr.h"
 
 using namespace WebCore;
 
 namespace WebKit {
 
 DragDestinationAction DragClientImpl::actionMaskForDrag(DragData*)
 {
     if (m_webView->client() && m_webView->client()->acceptsLoadDrops())
         return DragDestinationActionAny;
 
     return static_cast<DragDestinationAction>(
         DragDestinationActionDHTML | DragDestinationActionEdit);
 }
 
-void DragClientImpl::startDrag(DragImageRef dragImage,
+void DragClientImpl::startDrag(DragImage* dragImage,
                                const IntPoint& dragImageOrigin,
                                const IntPoint& eventPos,
                                Clipboard* clipboard,
                                Frame* frame,
                                bool isLinkDrag)
 {
     // Add a ref to the frame just in case a load occurs mid-drag.
     RefPtr<Frame> frameProtector = frame;
 
     WebDragData dragData = static_cast<ClipboardChromium*>(clipboard)->dataObject();
-
-    DragOperation dragOperationMask = clipboard->sourceOperation();
-
+    WebDragOperationsMask dragOperationMask = static_cast<WebDragOperationsMask>(clipboard->sourceOperation());
+    WebImage image;
     IntSize offsetSize(eventPos - dragImageOrigin);
     WebPoint offsetPoint(offsetSize.width(), offsetSize.height());
 
-    if (dragImage && dragImage->bitmap && m_webView->deviceScaleFactor() != dragImage->resolutionScale) {
-        ASSERT(dragImage->resolutionScale > 0);
-        float scale = m_webView->deviceScaleFactor() / dragImage->resolutionScale;
-        dragImage = scaleDragImage(dragImage, WebCore::FloatSize(scale, scale));
+    if (dragImage) {
+        float resolutionScale = dragImage->resolutionScale();
+        if (m_webView->deviceScaleFactor() != resolutionScale) {
+            ASSERT(resolutionScale > 0);
+            float scale = m_webView->deviceScaleFactor() / resolutionScale;
+            dragImage->scale(scale, scale);
+        }
+        image = dragImage->bitmap();
     }
-    m_webView->startDragging(frame, dragData, static_cast<WebDragOperationsMask>(dragOperationMask), (dragImage && dragImage->bitmap) ? WebImage(*dragImage->bitmap) : WebImage(), offsetPoint);
+
+    m_webView->startDragging(frame, dragData, dragOperationMask, image, offsetPoint);
 }
 
 } // namespace WebKit