Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16703005: Use a direct include of strings headers in chrome/browser/d*/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, vsevik, benjhayden+dwatch_chromium.org, yurys, chromium-apps-reviews_chromium.org, pfeldman
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/browser/d*/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M chrome/browser/devtools/adb_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_file_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/tethering_adb_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/do_not_track_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_item_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_item_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_query.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_query_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_shelf_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16703005/1
7 years, 6 months ago (2013-06-10 16:00:46 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 20:49:12 UTC) #2
Message was sent while issue was closed. 
Change committed as 205300

Powered by Google App Engine
This is Rietveld 408576698