Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 16700002: Remove enclosingIntRect(const IntRect&) and adjust all call sites. (Closed)

Created:
7 years, 6 months ago by jbroman
Modified:
7 years, 6 months ago
Reviewers:
jamesr, pdr., danakj1, eseidel
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, jchaffraix+rendering, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Rik, apavlov+blink_chromium.org, danakj, Stephen Chennney, aandrey+blink_chromium.org, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove enclosingIntRect(const IntRect&) and adjust all call sites. BUG=247934 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152087

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/IntRect.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbroman
7 years, 6 months ago (2013-06-09 02:38:35 UTC) #1
pdr.
On 2013/06/09 02:38:35, jbroman wrote: LGTM
7 years, 6 months ago (2013-06-09 02:48:03 UTC) #2
danakj
Personally, I'd rather see the explicit enclosingIntRect stay, and instead remove the implicit float->int conversion ...
7 years, 6 months ago (2013-06-09 06:14:47 UTC) #3
danakj1
oh, from the bug I see this is about enclosingIntRect(IntRect) so please disregard my last ...
7 years, 6 months ago (2013-06-09 06:16:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/16700002/2001
7 years, 6 months ago (2013-06-09 13:45:07 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-09 17:15:03 UTC) #6
Message was sent while issue was closed.
Change committed as 152087

Powered by Google App Engine
This is Rietveld 408576698