Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issue 16699002: bookmarks: Get rid of IDS_BOOKMARK_MANAGER_TOOLS_MENU. (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

bookmarks: Get rid of IDS_BOOKMARK_MANAGER_TOOLS_MENU. The Bookmark Manager does not have a "Tools" menu anymore (it was present only in the Native implementation). The JS one just have an "Organize" menu. BUG=226228 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -31 lines) Patch
M chrome/app/bookmarks_strings.grdp View 4 chunks +20 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
7 years, 6 months ago (2013-06-08 23:51:35 UTC) #1
sky
LGTM
7 years, 6 months ago (2013-06-10 15:41:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16699002/1
7 years, 6 months ago (2013-06-13 19:36:13 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 23:08:21 UTC) #4
Message was sent while issue was closed.
Change committed as 206197

Powered by Google App Engine
This is Rietveld 408576698