Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 16693003: Allow continuation after download is interrupted before initial rename. (Closed)

Created:
7 years, 6 months ago by asanka
Modified:
7 years, 6 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, darin-cc_chromium.org, jam, joi+watch-content_chromium.org
Visibility:
Public.

Description

Allow continuation after download is interrupted before initial rename. If the download was interrupted before target determination, we wouldn't set the FullPath causing the download to be restarted when resumed. We should set the Fullpath so that it can continue instead if possible. BUG=7648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M content/browser/download/download_item_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 2 chunks +72 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
asanka
7 years, 6 months ago (2013-06-10 21:06:41 UTC) #1
Randy Smith (Not in Mondays)
LGTM>
7 years, 6 months ago (2013-06-11 18:38:16 UTC) #2
asanka
On 2013/06/11 18:38:16, rdsmith wrote: > LGTM> Thanks!
7 years, 6 months ago (2013-06-11 18:38:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/16693003/1
7 years, 6 months ago (2013-06-11 18:39:04 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-11 22:39:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/16693003/1
7 years, 6 months ago (2013-06-12 15:46:38 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 18:31:42 UTC) #7
Message was sent while issue was closed.
Change committed as 205880

Powered by Google App Engine
This is Rietveld 408576698