Issue 16690003: Update tests to not use to-be-removed V8 handle operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16690003: Update tests to not use to-be-removed V8 handle operations. (Closed)

Created:
7 years, 6 months ago by marja

Modified:
7 years, 6 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit), sky, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update tests to not use to-be-removed V8 handle operations. (See bug.) BUG=236290 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205408

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -89 lines)			Patch
M	chrome/test/base/v8_unit_test.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/test/base/v8_unit_test.cc	View		5 chunks	+22 lines, -18 lines	0 comments	Download
M	content/renderer/v8_value_converter_impl_unittest.cc	View	1 2	25 chunks	+88 lines, -56 lines	0 comments	Download
M	webkit/plugins/ppapi/v8_var_converter_unittest.cc	View	1 2	5 chunks	+17 lines, -14 lines	0 comments	Download

Total messages: 7 (0 generated)

marja

Could you review the following: dcarney: V8 API usage correctness OWNERS rubberstamps: sky: chrome/test/* piman: ...

7 years, 6 months ago (2013-06-10 09:38:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/16690003/16001

7 years, 6 months ago (2013-06-10 18:00:59 UTC) #6

Message was sent while issue was closed.

Change committed as 205408