Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: build/android/buildbot/tests/bb_run_bot_test.py

Issue 16688002: Port remaining android buildbot code into python (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/buildbot/env_to_json.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/tests/bb_run_bot_test.py
diff --git a/build/android/buildbot/tests/bb_run_bot_test.py b/build/android/buildbot/tests/bb_run_bot_test.py
index 968ebc234705f022baf5f27da7e8d2e20c02ec01..3b028795ba15d470af13ccee4eeb41b5d4e7df40 100755
--- a/build/android/buildbot/tests/bb_run_bot_test.py
+++ b/build/android/buildbot/tests/bb_run_bot_test.py
@@ -14,14 +14,16 @@ import bb_run_bot
def main():
code = 0
- for bot_id in bb_run_bot.GetBotStepMap():
- proc = subprocess.Popen(
- [os.path.join(BUILDBOT_DIR, 'bb_run_bot.py'), '--bot-id', bot_id,
- '--TESTING'], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+ procs = [
+ (bot, subprocess.Popen(
+ [os.path.join(BUILDBOT_DIR, 'bb_run_bot.py'), '--bot-id', bot,
+ '--testing'], stdout=subprocess.PIPE, stderr=subprocess.PIPE))
+ for bot in bb_run_bot.GetBotStepMap()]
+ for bot, proc in procs:
_, err = proc.communicate()
code |= proc.returncode
if proc.returncode != 0:
- print 'Error running bb_run_bot with id="%s"' % bot_id, err
+ print 'Error running bb_run_bot with id="%s"' % bot, err
return code
« no previous file with comments | « build/android/buildbot/env_to_json.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698