service/datastore/properties.go - Issue 1667403003: Add support for uint8, uint16 and uint32 in luci/gae

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/properties.go

Issue 1667403003: Add support for uint8, uint16 and uint32 in luci/gae (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: allow negative Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/properties.go

diff --git a/service/datastore/properties.go b/service/datastore/properties.go

index b962e3ad033c901f591cce3b9bd6bee28e30dcab..3b91c35e7c6b3144752bf3c3276ddfe6e28af398 100644

--- a/service/datastore/properties.go

+++ b/service/datastore/properties.go

@@ -304,6 +304,8 @@ func UpconvertUnderlyingType(o interface{}) interface{} {

switch v.Kind() {

case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:

o = v.Int()

+ case reflect.Uint8, reflect.Uint16, reflect.Uint32:

+ o = int64(v.Uint())

case reflect.Bool:

o = v.Bool()

case reflect.String:

« no previous file with comments | « service/datastore/pls_test.go ('k') | service/datastore/properties_test.go » ('j') | no next file with comments »