Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 16667013: Use a direct include of strings headers in base/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jar (doing other things), gavinp+memory_chromium.org, sail+watch_chromium.org, asvitkine+watch_chromium.org, erikwright+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Use a direct include of strings headers in base/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M base/json/json_value_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_value_serializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/string_escape.h View 1 chunk +1 line, -1 line 0 comments Download
M base/json/string_escape.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/linux_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/location.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/authorization_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/libdispatch_task_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/linked_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/metrics/field_trial_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/histogram.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/metrics/histogram_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/metrics/sparse_histogram.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/sparse_histogram_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/statistics_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/native_library.h View 1 chunk +1 line, -1 line 0 comments Download
M base/native_library_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/nix/mime_util_xdg.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/nullable_string16.h View 1 chunk +1 line, -1 line 0 comments Download
M base/os_compat_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/path_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/pickle.h View 1 chunk +1 line, -1 line 0 comments Download
M base/pickle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_registry_simple.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16667013/1
7 years, 6 months ago (2013-06-10 14:44:42 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 19:06:58 UTC) #2
Message was sent while issue was closed.
Change committed as 205261

Powered by Google App Engine
This is Rietveld 408576698