Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 16658011: Add "lsan" to GYP options (enables LeakSanitizer). (Closed)

Created:
7 years, 6 months ago by earthdok_at_google
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M build/common.gypi View 6 chunks +28 lines, -4 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
earthdok
7 years, 6 months ago (2013-06-11 17:38:14 UTC) #1
Alexander Potapenko
LGTM Nico, FYI
7 years, 6 months ago (2013-06-13 11:48:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@google.com/16658011/1
7 years, 6 months ago (2013-06-13 11:57:17 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-13 12:07:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@google.com/16658011/1
7 years, 6 months ago (2013-06-13 12:31:04 UTC) #5
commit-bot: I haz the power
Change committed as 206074
7 years, 6 months ago (2013-06-13 15:49:56 UTC) #6
Nico
lgtm https://chromiumcodereview.appspot.com/16658011/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/16658011/diff/1/build/common.gypi#newcode3192 build/common.gypi:3192: ], fyi: cflags and ldflags are linux-only (in ...
7 years, 6 months ago (2013-06-13 15:54:48 UTC) #7
Alexander Potapenko
7 years, 6 months ago (2013-06-14 09:39:58 UTC) #8
Message was sent while issue was closed.
On 2013/06/13 15:54:48, Nico wrote:
> lgtm
> 
> https://chromiumcodereview.appspot.com/16658011/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/16658011/diff/1/build/common.gypi#newc...
> build/common.gypi:3192: ],
> fyi: cflags and ldflags are linux-only (in case you're expecting this to work
on
> os x)

This isn't going to work on osx in the nearest future.

Powered by Google App Engine
This is Rietveld 408576698