[android_webview] Add view integration test for content size.

[android_webview] Add view integration test for content size.

This adds a view integration test for content size changes in
wrap-content mode.

BUG=None
TEST=AndroidWebViewTests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208309

[mkosiba (inactive), 2013-06-11 17:25:08]

PTAL (this is _not_ the test we were talking about, this one should be passing
fine and is to keep us from regressing wrap content mode sizing).

[joth, 2013-06-11 19:18:05]

some questions for my understanding of this...

https://codereview.chromium.org/16658010/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
(right):

https://codereview.chromium.org/16658010/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java:244:
mOnContentSizeChangedHelper, contentWidthCss, contentHeightCss);
Remind me of the limitations of wrap content w.r.t. width? This was discouraged,
rather than outright not supported?

https://codereview.chromium.org/16658010/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java:246:
Thread.sleep(CONTENT_SIZE_CHANGE_STABILITY_TIMEOUT_MS);
loadPageOfSizeAndWaitForSizeChange() already checks that "helper.getHeight() ==
heightCss && helper.getWidth() == widthCss" internally, so I'm not fully clear
what the sleep and additional two asserts here are for?

[mkosiba (inactive), 2013-06-12 15:45:29]

https://codereview.chromium.org/16658010/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
(right):

https://codereview.chromium.org/16658010/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java:244:
mOnContentSizeChangedHelper, contentWidthCss, contentHeightCss);
On 2013/06/11 19:18:05, joth wrote:
> Remind me of the limitations of wrap content w.r.t. width? This was
discouraged,
> rather than outright not supported?

If you set width to wrap content the AwLayoutSizer will try and set the Java
view's width to be equal to the parent's width.

This isn't what we're testing here though. The assertion is that when you have a
0x0 WebView and load content that has a known size you'll get the content size
changed notification back with the right values.

I'll rename the test and update this to use a detached view, which should take
the AwLayoutSizer out of the picture.

https://codereview.chromium.org/16658010/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java:246:
Thread.sleep(CONTENT_SIZE_CHANGE_STABILITY_TIMEOUT_MS);
On 2013/06/11 19:18:05, joth wrote:
> loadPageOfSizeAndWaitForSizeChange() already checks that "helper.getHeight()
==
> heightCss && helper.getWidth() == widthCss" internally, so I'm not fully clear
> what the sleep and additional two asserts here are for?

I'll add a comment. This is to make sure that the size doesn't arbitrarily grow
after reaching the target value.

[mkosiba (inactive), 2013-06-20 10:37:02]

ping?

[mkosiba (inactive), 2013-06-21 13:25:49]

Ben,
   Since Joth is out could you PTAL?

[benm (inactive), 2013-06-21 13:49:40]

https://codereview.chromium.org/16658010/diff/15001/android_webview/javatests...
File
android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
(right):

https://codereview.chromium.org/16658010/diff/15001/android_webview/javatests...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java:220:
final int maxSizeChangeNotificationsToWaitFor = 5;
add a comment to explain why this doesn't happen on the first callback?

Can we wait indefinitely for the size to be right and let the test timeout fail
us if it doesn't arrive?

[joth, 2013-06-22 01:22:01]

sorry for delay. lgtm for changes since my last look

[commit-bot: I haz the power, 2013-06-24 19:18:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/16658010/26001

[commit-bot: I haz the power, 2013-06-25 00:00:25]

Change committed as 208309