Issue 16656002: Take all uses into account to clear int32 truncation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16656002: Take all uses into account to clear int32 truncation. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Take all uses into account to clear int32 truncation. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15017

Patch Set 2 : Space man #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -19 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-int32-truncation.js	View	1	1 chunk	+27 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://chromiumcodereview.appspot.com/16656002/diff/1/test/mjsunit/regress/regress-int32-truncation.js File test/mjsunit/regress/regress-int32-truncation.js (right): https://chromiumcodereview.appspot.com/16656002/diff/1/test/mjsunit/regress/regress-int32-truncation.js#newcode43 test/mjsunit/regress/regress-int32-truncation.js:43: assertEquals((1<<30)*2, f(30, true)); nit: spaces ...

7 years, 6 months ago (2013-06-07 17:22:45 UTC) #2

Toon Verwaest

7 years, 6 months ago (2013-06-07 17:28:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15017 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16656002: Take all uses into account to clear int32 truncation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Space man #

Messages