Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16652007: Use a direct include of strings headers in net/test/, net/third_party/, net/tools/, net/udp/, net/u… (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in net/test/, net/third_party/, net/tools/, net/udp/, net/url_request/, net/websockets/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -78 lines) Patch
M net/test/embedded_test_server/embedded_test_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/embedded_test_server/http_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/embedded_test_server/http_response.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/python_utils_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/local_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/spawned_test_server/local_test_server_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/local_test_server_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/remote_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/mozilla_security_manager/nsPKCS12Blob.h View 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/crl_set_dump/crl_set_dump.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/dump_cache.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/dump_cache/upgrade_win.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/upgrade_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/dump_cache/url_to_filename_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/url_to_filename_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/url_to_filename_encoder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/dump_cache/url_utilities.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/dump_cache/url_utilities_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/fetch/fetch_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/fetch/http_listen_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/flip_server/balsa_headers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/gdig/gdig.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/get_server_time/get_server_time.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/spdy_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/tld_cleanup/tld_cleanup_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_net_log_parameters.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_netlog_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_test_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_throttler_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_throttler_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_throttler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/url_request/view_cache_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_frame_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_handshake_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/websockets/websocket_handshake_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_job_spdy2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_job_spdy3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_net_log_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_throttle.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16652007/1
7 years, 6 months ago (2013-06-10 21:51:07 UTC) #1
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=48417
7 years, 6 months ago (2013-06-11 02:15:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16652007/1
7 years, 6 months ago (2013-06-11 03:37:29 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 07:15:52 UTC) #4
Message was sent while issue was closed. 
Change committed as 205447

Powered by Google App Engine
This is Rietveld 408576698