Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3365)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 16650002: Add UMA tracking to "Recently Closed" submenu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Histogram recent tabs submenu usage. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
index 0c0ed93ddb358b317cbc94b92657bd1c78b1abe7..7cae80d245ed13d53f233e4a0773cbfe71b68648 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h"
#include "base/bind.h"
+#include "base/metrics/histogram.h"
#include "base/strings/string_number_conversions.h"
#include "base/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
@@ -112,6 +113,14 @@ int CommandIdToWindowModelIndex(int command_id) {
} // namepace
+enum RecentTabAction {
+ LOCAL_SESSION_TAB = 0,
+ OTHER_DEVICE_TAB,
+ RESTORE_WINDOW,
+ SHOW_MORE,
+ LIMIT_RECENT_TAB_ACTION
+};
+
// An element in |RecentTabsSubMenuModel::tab_navigation_items_| that stores
// the navigation information of a local or foreign tab required to restore the
// tab.
@@ -198,6 +207,8 @@ bool RecentTabsSubMenuModel::GetAcceleratorForCommandId(
void RecentTabsSubMenuModel::ExecuteCommand(int command_id, int event_flags) {
if (command_id == IDC_SHOW_HISTORY) {
+ UMA_HISTOGRAM_ENUMERATION("WrenchMenu.RecentTabsSubMenu", SHOW_MORE,
+ LIMIT_RECENT_TAB_ACTION);
// We show all "other devices" on the history page.
chrome::ExecuteCommandWithDisposition(browser_, IDC_SHOW_HISTORY,
ui::DispositionFromEventFlags(event_flags));
@@ -226,6 +237,8 @@ void RecentTabsSubMenuModel::ExecuteCommand(int command_id, int event_flags) {
if (item.session_tag.empty()) { // Restore tab of local session.
if (service && delegate) {
+ UMA_HISTOGRAM_ENUMERATION("WrenchMenu.RecentTabsSubMenu",
+ LOCAL_SESSION_TAB, LIMIT_RECENT_TAB_ACTION);
service->RestoreEntryById(delegate, item.tab_id,
browser_->host_desktop_type(), disposition);
}
@@ -238,6 +251,8 @@ void RecentTabsSubMenuModel::ExecuteCommand(int command_id, int event_flags) {
return;
if (tab->navigations.empty())
return;
+ UMA_HISTOGRAM_ENUMERATION("WrenchMenu.RecentTabsSubMenu",
+ OTHER_DEVICE_TAB, LIMIT_RECENT_TAB_ACTION);
SessionRestore::RestoreForeignSessionTab(
browser_->tab_strip_model()->GetActiveWebContents(),
*tab, disposition);
@@ -248,6 +263,8 @@ void RecentTabsSubMenuModel::ExecuteCommand(int command_id, int event_flags) {
int model_idx = CommandIdToWindowModelIndex(command_id);
DCHECK(model_idx >= 0 &&
model_idx < static_cast<int>(window_items_.size()));
+ UMA_HISTOGRAM_ENUMERATION("WrenchMenu.RecentTabsSubMenu", RESTORE_WINDOW,
+ LIMIT_RECENT_TAB_ACTION);
service->RestoreEntryById(delegate, window_items_[model_idx],
browser_->host_desktop_type(), disposition);
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698