Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 16650002: Add UMA tracking to "Recently Closed" submenu. (Closed)

Created:
7 years, 6 months ago by Kristen Dwan
Modified:
7 years, 6 months ago
Reviewers:
MAD, Ilya Sherman, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add UMA tracking to "Recently Closed" submenu. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207717

Patch Set 1 #

Patch Set 2 : Histogram recent tabs submenu usage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 6 chunks +17 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Kristen Dwan
7 years, 6 months ago (2013-06-07 16:20:23 UTC) #1
MAD
I think we should use a histogram instead, named RecentTabsSubMenu and with individual values for ...
7 years, 6 months ago (2013-06-07 17:47:50 UTC) #2
Kristen Dwan
On 2013/06/07 17:47:50, MAD wrote: > I think we should use a histogram instead, named ...
7 years, 6 months ago (2013-06-07 18:00:15 UTC) #3
MAD
There is no Wrench menu histogram section, (you could add one if you want), and ...
7 years, 6 months ago (2013-06-07 18:15:01 UTC) #4
Kristen Dwan
Changed to histogram -
7 years, 6 months ago (2013-06-10 17:32:34 UTC) #5
MAD
LGTM! Thanks... BYE MAD
7 years, 6 months ago (2013-06-10 17:42:19 UTC) #6
Kristen Dwan
Ping - Ilya?
7 years, 6 months ago (2013-06-14 17:08:56 UTC) #7
Ilya Sherman
LGTM. Sorry, missed that I was listed as a reviewer for this CL.
7 years, 6 months ago (2013-06-15 00:00:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dwankri@chromium.org/16650002/6001
7 years, 6 months ago (2013-06-15 00:01:13 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=9345
7 years, 6 months ago (2013-06-15 00:14:16 UTC) #10
Kristen Dwan
sky - ptal? thanks.
7 years, 6 months ago (2013-06-20 20:16:58 UTC) #11
sky
LGTM
7 years, 6 months ago (2013-06-20 21:30:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dwankri@chromium.org/16650002/6001
7 years, 6 months ago (2013-06-20 21:44:19 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 05:29:31 UTC) #14
Message was sent while issue was closed.
Change committed as 207717

Powered by Google App Engine
This is Rietveld 408576698