Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 16648002: Enable TsfBridge to re-initialize (Closed)

Created:
7 years, 6 months ago by Yohei Yukawa
Modified:
7 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, kochi, Yuki, yoichio
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable TsfBridge to re-initialize Currently we cannot re-initialize TsfBridge once TsfBridge::Shutdown is called. This patch set gets rid of such limitation. This is mainly for unit test, where TsfBridge::Initialize is called in its Setup function. BUG=246534 TEST=Manually done with GoogleJapaneseInput. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205271

Patch Set 1 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -41 lines) Patch
M content/browser/browser_main_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/win/mock_tsf_bridge.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/base/ime/win/mock_tsf_bridge.cc View 3 chunks +1 line, -7 lines 0 comments Download
M ui/base/ime/win/tsf_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/win/tsf_bridge.cc View 7 chunks +36 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yohei Yukawa
7 years, 6 months ago (2013-06-07 15:14:05 UTC) #1
Seigo Nonaka
On 2013/06/07 15:14:05, Yohei Yukawa wrote: Sorry, could you add more description about why we ...
7 years, 6 months ago (2013-06-10 02:36:27 UTC) #2
Yohei Yukawa
On 2013/06/10 02:36:27, Seigo Nonaka wrote: > On 2013/06/07 15:14:05, Yohei Yukawa wrote: > > ...
7 years, 6 months ago (2013-06-10 02:47:00 UTC) #3
Seigo Nonaka
On 2013/06/10 02:47:00, Yohei Yukawa wrote: > On 2013/06/10 02:36:27, Seigo Nonaka wrote: > > ...
7 years, 6 months ago (2013-06-10 03:19:13 UTC) #4
Seigo Nonaka
lgtm
7 years, 6 months ago (2013-06-10 03:19:19 UTC) #5
Yohei Yukawa
+sky@ for the owner review. Could you take a look?
7 years, 6 months ago (2013-06-10 12:48:09 UTC) #6
sky
LGTM
7 years, 6 months ago (2013-06-10 14:43:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/16648002/13001
7 years, 6 months ago (2013-06-10 14:44:56 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 19:25:21 UTC) #9
Message was sent while issue was closed.
Change committed as 205271

Powered by Google App Engine
This is Rietveld 408576698