Precompilation: Make missing entry points an error.

runtime/vm/precompiler.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/precompiler.h"
 
 #include "vm/cha.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/hash_table.h"
@@ skipping 293 matching lines @@
   String& class_name = String::Handle(Z);
   String& function_name = String::Handle(Z);
 
   for (intptr_t i = 0; entry_points[i].library_uri != NULL; i++) {
     library_uri = Symbols::New(entry_points[i].library_uri);
     class_name = Symbols::New(entry_points[i].class_name);
     function_name = Symbols::New(entry_points[i].function_name);
 
     lib = Library::LookupLibrary(library_uri);
     if (lib.IsNull()) {
-      if (FLAG_trace_precompiler) {
-        THR_Print("WARNING: Missing %s\n", entry_points[i].library_uri);
-      }
-      continue;
+      String& msg = String::Handle(Z, String::NewFormatted(
+          "Cannot find entry point %s\n", entry_points[i].library_uri));
+      Jump(Error::Handle(Z, ApiError::New(msg)));
+      UNREACHABLE();
     }
 
     if (class_name.raw() == Symbols::TopLevel().raw()) {
-      func = lib.LookupFunctionAllowPrivate(function_name);
-      field = lib.LookupFieldAllowPrivate(function_name);
+      if (Library::IsPrivate(function_name)) {
+        function_name = lib.PrivateName(function_name);
+      }
+      func = lib.LookupLocalFunction(function_name);
+      field = lib.LookupLocalField(function_name);
     } else {
-      cls = lib.LookupClassAllowPrivate(class_name);
+      if (Library::IsPrivate(class_name)) {
+        class_name = lib.PrivateName(class_name);
+      }
+      cls = lib.LookupLocalClass(class_name);
       if (cls.IsNull()) {
-        if (FLAG_trace_precompiler) {
-          THR_Print("WARNING: Missing %s %s\n",
-                    entry_points[i].library_uri,
-                    entry_points[i].class_name);
-        }
-        continue;
+        String& msg = String::Handle(Z, String::NewFormatted(
+            "Cannot find entry point %s %s\n",
+            entry_points[i].library_uri,
+            entry_points[i].class_name));
+        Jump(Error::Handle(Z, ApiError::New(msg)));
+        UNREACHABLE();
       }
 
       ASSERT(!cls.IsNull());
       func = cls.LookupFunctionAllowPrivate(function_name);
       field = cls.LookupField(function_name);
     }
 
     if (func.IsNull() && field.IsNull()) {
-      if (FLAG_trace_precompiler) {
-        THR_Print("WARNING: Missing %s %s %s\n",
-                  entry_points[i].library_uri,
-                  entry_points[i].class_name,
-                  entry_points[i].function_name);
-      }
+     String& msg = String::Handle(Z, String::NewFormatted(

[Florian Schneider, 2016/02/04 21:51:48]

Uneven indentation?

[rmacnak, 2016/02/04 22:25:57]

Fixed

+          "Cannot find entry point %s %s %s\n",
+          entry_points[i].library_uri,
+          entry_points[i].class_name,
+          entry_points[i].function_name));
+      Jump(Error::Handle(Z, ApiError::New(msg)));
+      UNREACHABLE();
     }
 
     if (!func.IsNull()) {
       AddFunction(func);
       if (func.IsGenerativeConstructor()) {
         // Allocation stubs are referenced from the call site of the
         // constructor, not in the constructor itself. So compiling the
         // constructor isn't enough for us to discover the class is
         // instantiated if the class isn't otherwise instantiated from Dart
         // code and only instantiated from C++.
@@ skipping 910 matching lines @@
       cls = it.GetNextClass();
       if (cls.IsDynamicClass()) {
         continue;  // class 'dynamic' is in the read-only VM isolate.
       }
       cls.set_is_allocated(false);
     }
   }
 }
 
 }  // namespace dart