Allow self_size to be larger than 2GB in heap snapshots.

test/cctest/test-heap-profiler.cc

Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index 5c102e0c52bc290fba38004da13a7c18e036e9eb..40d4f67352616d19a21b4139886a2065115c8adc 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -234,9 +234,9 @@ TEST(HeapSnapshotObjectSizes) {
   CHECK_NE(NULL, x2);
 
   // Test sizes.
-  CHECK_NE(0, x->GetSelfSize());
-  CHECK_NE(0, x1->GetSelfSize());
-  CHECK_NE(0, x2->GetSelfSize());
+  CHECK_NE(0, x->GetShallowSize());

[Dmitry Lomov (no reviews), 2014/02/18 12:40:41]

IIRC, you'll need static_cast<int> to compile on Windows - make sure you run on
a try bot before landing (also below)

[alph, 2014/02/18 13:21:17]

Thank you! Added casts to be on the safe side.

+  CHECK_NE(0, x1->GetShallowSize());
+  CHECK_NE(0, x2->GetShallowSize());
 }
 
 
@@ -2067,7 +2067,7 @@ TEST(AllocationSitesAreVisible) {
                   "elements");
   CHECK_NE(NULL, elements);
   CHECK_EQ(v8::HeapGraphNode::kArray, elements->GetType());
-  CHECK_EQ(v8::internal::FixedArray::SizeFor(3), elements->GetSelfSize());
+  CHECK_EQ(v8::internal::FixedArray::SizeFor(3), elements->GetShallowSize());
 
   v8::Handle<v8::Value> array_val =
       heap_profiler->FindObjectById(transition_info->GetId());
@@ -2384,7 +2384,7 @@ TEST(ArrayBufferAndArrayBufferView) {
   const v8::HeapGraphNode* backing_store =
       GetProperty(arr1_buffer, v8::HeapGraphEdge::kInternal, "backing_store");
   CHECK_NE(NULL, backing_store);
-  CHECK_EQ(400, backing_store->GetSelfSize());
+  CHECK_EQ(400, backing_store->GetShallowSize());
 }