Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/api.cc

Issue 166383002: Allow self_size to be larger than 2GB in heap snapshots. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap-snapshot-generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index dfde26565b1393bfa4de6f36b7844e3698c29586..fe822fa826c50d164a4dd862f91c2c6f0be18ef5 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6971,7 +6971,9 @@ SnapshotObjectId HeapGraphNode::GetId() const {
int HeapGraphNode::GetSelfSize() const {
- return ToInternal(this)->self_size();
+ size_t size = ToInternal(this)->self_size();
loislo 2014/02/14 13:26:02 please introduce GetShallowSize with size_t return
alph 2014/02/17 16:57:52 Done.
+ CHECK(size <= static_cast<size_t>(internal::kMaxInt));
+ return static_cast<int>(size);
}
« no previous file with comments | « no previous file | src/heap-snapshot-generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698