Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 16627004: [Android] Add --skip-deps-push to test scripts. (Closed)

Created:
7 years, 6 months ago by frankf
Modified:
7 years, 6 months ago
Reviewers:
craigdh, nilesh
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, nyquist
Visibility:
Public.

Description

[Android] Add --skip-deps-push to test scripts. This bypasses syncing any deps to the device to speed up the developer workflow. BUG=243447 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205317

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M build/android/pylib/base/base_test_runner.py View 3 chunks +8 lines, -2 lines 1 comment Download
M build/android/pylib/browsertests/dispatch.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/dispatch.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 2 chunks +3 lines, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +3 lines, -1 line 0 comments Download
M build/android/pylib/utils/test_options_parser.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
frankf
7 years, 6 months ago (2013-06-10 21:00:00 UTC) #1
craigdh
lgtm.
7 years, 6 months ago (2013-06-10 21:13:00 UTC) #2
nilesh
On 2013/06/10 21:13:00, craigdh wrote: > lgtm. LGTM
7 years, 6 months ago (2013-06-10 21:45:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/16627004/1
7 years, 6 months ago (2013-06-10 21:47:37 UTC) #4
commit-bot: I haz the power
Change committed as 205317
7 years, 6 months ago (2013-06-10 21:50:56 UTC) #5
nilesh
https://codereview.chromium.org/16627004/diff/1/build/android/pylib/base/base_test_runner.py File build/android/pylib/base/base_test_runner.py (right): https://codereview.chromium.org/16627004/diff/1/build/android/pylib/base/base_test_runner.py#newcode93 build/android/pylib/base/base_test_runner.py:93: self.PushDependencies() This causes the apk install to be skipped ...
7 years, 6 months ago (2013-06-12 17:25:12 UTC) #6
frankf
On 2013/06/12 17:25:12, nilesh wrote: > https://codereview.chromium.org/16627004/diff/1/build/android/pylib/base/base_test_runner.py > File build/android/pylib/base/base_test_runner.py (right): > > https://codereview.chromium.org/16627004/diff/1/build/android/pylib/base/base_test_runner.py#newcode93 > ...
7 years, 6 months ago (2013-06-12 17:38:04 UTC) #7
nilesh
On 2013/06/12 17:38:04, frankf wrote: > On 2013/06/12 17:25:12, nilesh wrote: > > > https://codereview.chromium.org/16627004/diff/1/build/android/pylib/base/base_test_runner.py ...
7 years, 6 months ago (2013-06-12 17:47:05 UTC) #8
nilesh
+nyquist
7 years, 6 months ago (2013-06-12 17:48:13 UTC) #9
craigdh
On 2013/06/12 17:48:13, nilesh wrote: > +nyquist This also shouldn't interfere with the behavior of ...
7 years, 6 months ago (2013-06-12 17:52:43 UTC) #10
frankf
7 years, 6 months ago (2013-06-12 18:23:29 UTC) #11
Message was sent while issue was closed.
On 2013/06/12 17:47:05, nilesh wrote:
> On 2013/06/12 17:38:04, frankf wrote:
> > On 2013/06/12 17:25:12, nilesh wrote:
> > >
> >
>
https://codereview.chromium.org/16627004/diff/1/build/android/pylib/base/base...
> > > File build/android/pylib/base/base_test_runner.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/16627004/diff/1/build/android/pylib/base/base...
> > > build/android/pylib/base/base_test_runner.py:93: self.PushDependencies()
> > > This causes the apk install to be skipped as well. I dont think skipping
the
> > apk
> > > install was intended. Was it?
> > 
> > Yes, this is a heavy-handed approach as we consider the apk as part of deps.
> If
> > it causes confusion/inconvinience, I can change it. WDYT?
> 
> I think pushing the new APK is integral part of developer workflow.
> Typical workflow (Add a test case, run, modify, run ..) While doing so the
> developer does not want to push all the data dependencies specified for all
the
> tests in the APK.
> 
> What workflow did you have in mind?

Agreed: https://codereview.chromium.org/16820002/

Powered by Google App Engine
This is Rietveld 408576698