chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc - Issue 16625012: Remove ExtensionURLInfo, make security decisions in render process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc

Issue 16625012: Remove ExtensionURLInfo, make security decisions in render process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc

diff --git a/chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc b/chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc

index fc3cc4635b3c898a7c4b7acc0bfcf193d39a4731..965281b0bade5ef02df3d466ff52d9f7aef0c392 100644

--- a/chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc

+++ b/chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc

@@ -251,7 +251,7 @@ string16 ChromeJavaScriptDialogManager::GetTitle(const GURL& origin_url,

if (extension_host_) {

const extensions::Extension* extension = extension_host_->

profile()->GetExtensionService()->extensions()->

- GetExtensionOrAppByURL(ExtensionURLInfo(origin_url));

+ GetExtensionOrAppByURL(origin_url);

if (extension) {

return UTF8ToUTF16(base::StringPiece(extension->name()));

}

« no previous file with comments | « chrome/browser/tab_contents/tab_util.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »