Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16625004: components: Move user_prefs into user_prefs namespace. (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
Reviewers:
Lei Zhang, joth, Jói
CC:
chromium-reviews, nkostylev+watch_chromium.org, ahutter, yoshiki+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, Raman Kakilate, Ilya Sherman, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-autofill_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, dbeam+watch-options_chromium.org, dyu1, browser-components-watch_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, Albert Bodenhamer, ctguil+watch_chromium.org, rouslan+autofillwatch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, sail+watch_chromium.org, davidbarr+watch_chromium.org, benquan, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -41 lines) Patch
M android_webview/browser/aw_autofill_manager_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/home_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_common_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_download.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/browser/autofill_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/personal_data_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/browser_context_keyed_service/browser_context_keyed_base_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/user_prefs/user_prefs.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/user_prefs/user_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
Nothing really excited :( Jonathan android_webview/ Lei chrome/ Joi components/ Note: Uploading from my grandmother's ...
7 years, 6 months ago (2013-06-08 23:26:31 UTC) #1
Lei Zhang
chrome/ lgtm. Happy to see you got uploads working.
7 years, 6 months ago (2013-06-09 01:55:16 UTC) #2
joth
aw/ lgtm rubberstamp
7 years, 6 months ago (2013-06-09 16:54:57 UTC) #3
Jói
LGTM, thanks. On Sun, Jun 9, 2013 at 5:54 PM, <joth@chromium.org> wrote: > aw/ lgtm ...
7 years, 6 months ago (2013-06-09 18:49:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16625004/1
7 years, 6 months ago (2013-06-11 01:02:27 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 13:00:19 UTC) #6
Message was sent while issue was closed. 
Change committed as 205517

Powered by Google App Engine
This is Rietveld 408576698