Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 16622003: Better error message in app.window.current() when called from bg page. (Closed)

Created:
7 years, 6 months ago by zhchbin
Modified:
7 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Better error message in app.window.current() when called from bg page. BUG=179735 TEST=Call app.window.current() in the bg page. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/renderer/resources/extensions/app_window_custom_bindings.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
zhchbin
Hi mek, better error message as crbug.com/179735 description. Please review.
7 years, 6 months ago (2013-06-10 11:46:36 UTC) #1
Marijn Kruisselbrink
lgtm
7 years, 6 months ago (2013-06-11 19:48:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/16622003/1
7 years, 6 months ago (2013-06-12 00:18:28 UTC) #3
zhchbin
Please review, presubmit failed because missing LGTM from the owner.
7 years, 6 months ago (2013-06-12 01:37:37 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8537
7 years, 6 months ago (2013-06-12 03:16:26 UTC) #5
Yoyo Zhou
LGTM
7 years, 6 months ago (2013-06-12 18:25:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/16622003/1
7 years, 6 months ago (2013-06-13 07:57:31 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-13 08:15:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/16622003/1
7 years, 6 months ago (2013-06-13 15:28:25 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 19:47:26 UTC) #10
Message was sent while issue was closed.
Change committed as 206140

Powered by Google App Engine
This is Rietveld 408576698