Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 1661703002: VM: Replace dart --noopt with new binary target dart_noopt. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 String suffix = executableBinarySuffix; 205 String suffix = executableBinarySuffix;
206 dartExecutable = useSdk 206 dartExecutable = useSdk
207 ? '$buildDir/dart-sdk/bin/dart$suffix' 207 ? '$buildDir/dart-sdk/bin/dart$suffix'
208 : '$buildDir/dart$suffix'; 208 : '$buildDir/dart$suffix';
209 } 209 }
210 210
211 TestUtils.ensureExists(dartExecutable, configuration); 211 TestUtils.ensureExists(dartExecutable, configuration);
212 return dartExecutable; 212 return dartExecutable;
213 } 213 }
214 214
215 String get dartVmNooptBinaryFileName {
216 // Controlled by user with the option "--dart".
217 String dartExecutable = configuration['dart'];
218
219 if (dartExecutable == '') {
220 String suffix = executableBinarySuffix;
221 dartExecutable = useSdk
222 ? '$buildDir/dart-sdk/bin/dart_noopt$suffix'
223 : '$buildDir/dart_noopt$suffix';
224 }
225
226 TestUtils.ensureExists(dartExecutable, configuration);
227 return dartExecutable;
228 }
229
215 String get dartPrecompiledBinaryFileName { 230 String get dartPrecompiledBinaryFileName {
216 // Controlled by user with the option "--dart_precompiled". 231 // Controlled by user with the option "--dart_precompiled".
217 String dartExecutable = configuration['dart_precompiled']; 232 String dartExecutable = configuration['dart_precompiled'];
218 233
219 if (dartExecutable == null || dartExecutable == '') { 234 if (dartExecutable == null || dartExecutable == '') {
220 String suffix = executableBinarySuffix; 235 String suffix = executableBinarySuffix;
221 dartExecutable = '$buildDir/dart_precompiled_runtime$suffix'; 236 dartExecutable = '$buildDir/dart_precompiled_runtime$suffix';
222 } 237 }
223 238
224 TestUtils.ensureExists(dartExecutable, configuration); 239 TestUtils.ensureExists(dartExecutable, configuration);
(...skipping 2218 matching lines...) Expand 10 before | Expand all | Expand 10 after
2443 for (var key in PATH_REPLACEMENTS.keys) { 2458 for (var key in PATH_REPLACEMENTS.keys) {
2444 if (path.startsWith(key)) { 2459 if (path.startsWith(key)) {
2445 path = path.replaceFirst(key, PATH_REPLACEMENTS[key]); 2460 path = path.replaceFirst(key, PATH_REPLACEMENTS[key]);
2446 break; 2461 break;
2447 } 2462 }
2448 } 2463 }
2449 } 2464 }
2450 return path; 2465 return path;
2451 } 2466 }
2452 } 2467 }
OLDNEW
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698