Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: Source/core/page/DragController.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/TextFieldDecorationElement.cpp ('k') | Source/core/svg/SVGImageElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/DragController.cpp
diff --git a/Source/core/page/DragController.cpp b/Source/core/page/DragController.cpp
index a7668bd5174211d56272a8a811e84f4ff36c1f87..0dbef2f8526253b518db14004b59f12492dba45e 100644
--- a/Source/core/page/DragController.cpp
+++ b/Source/core/page/DragController.cpp
@@ -812,8 +812,12 @@ bool DragController::startDrag(Frame* src, const DragState& state, DragOperation
}
doSystemDrag(dragImage, dragLoc, mouseDraggedPoint, clipboard, src, true);
} else if (state.m_dragType == DragSourceActionDHTML) {
- ASSERT(m_dragSourceAction & DragSourceActionDHTML);
- doSystemDrag(dragImage, dragLoc, dragOrigin, clipboard, src, false);
+ if (dragImage) {
+ ASSERT(m_dragSourceAction & DragSourceActionDHTML);
+ doSystemDrag(dragImage, dragLoc, dragOrigin, clipboard, src, false);
+ } else {
+ startedDrag = false;
+ }
} else {
// draggableNode() determined an image or link node was draggable, but it turns out the
// image or link had no URL, so there is nothing to drag.
« no previous file with comments | « Source/core/html/shadow/TextFieldDecorationElement.cpp ('k') | Source/core/svg/SVGImageElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698