Source/core/html/shadow/SpinButtonElement.h - Issue 16599003: :hover style not applied on hover if its display property is different from original style's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/SpinButtonElement.h

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/shadow/SpinButtonElement.h

diff --git a/Source/core/html/shadow/SpinButtonElement.h b/Source/core/html/shadow/SpinButtonElement.h

index f2259be34979dd0a4e5171304885237a8eff9617..03f7da403c21f535de89f9d6b32c6abb057799d9 100644

--- a/Source/core/html/shadow/SpinButtonElement.h

+++ b/Source/core/html/shadow/SpinButtonElement.h

@@ -69,7 +69,7 @@ public:

private:

SpinButtonElement(Document*, SpinButtonOwner&);

- virtual void detach();

+ virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;

virtual bool isSpinButtonElement() const { return true; }

virtual bool isDisabledFormControl() const OVERRIDE { return shadowHost() && shadowHost()->isDisabledFormControl(); }

virtual bool matchesReadOnlyPseudoClass() const OVERRIDE;

« no previous file with comments | « Source/core/html/shadow/SliderThumbElement.cpp ('k') | Source/core/html/shadow/SpinButtonElement.cpp » ('j') | no next file with comments »