Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: Source/core/html/HTMLPlugInImageElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLPlugInImageElement.h ('k') | Source/core/html/HTMLProgressElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLPlugInImageElement.cpp
diff --git a/Source/core/html/HTMLPlugInImageElement.cpp b/Source/core/html/HTMLPlugInImageElement.cpp
index 8c782ef47c552c55cdf9b44267b9aa1a4a60f82b..622dbc28b1f6355a22c7fa81bab7f41a03923d35 100644
--- a/Source/core/html/HTMLPlugInImageElement.cpp
+++ b/Source/core/html/HTMLPlugInImageElement.cpp
@@ -159,7 +159,7 @@ void HTMLPlugInImageElement::willRecalcStyle(StyleChange)
reattach();
}
-void HTMLPlugInImageElement::attach()
+void HTMLPlugInImageElement::attach(const AttachContext& context)
{
PostAttachCallbackDisabler disabler(this);
@@ -168,7 +168,7 @@ void HTMLPlugInImageElement::attach()
if (!isImage)
queuePostAttachCallback(&HTMLPlugInImageElement::updateWidgetCallback, this);
- HTMLPlugInElement::attach();
+ HTMLPlugInElement::attach(context);
if (isImage && renderer() && !useFallbackContent()) {
if (!m_imageLoader)
@@ -177,7 +177,7 @@ void HTMLPlugInImageElement::attach()
}
}
-void HTMLPlugInImageElement::detach()
+void HTMLPlugInImageElement::detach(const AttachContext& context)
{
// FIXME: Because of the insanity that is HTMLPlugInImageElement::recalcStyle,
// we can end up detaching during an attach() call, before we even have a
@@ -185,7 +185,7 @@ void HTMLPlugInImageElement::detach()
if (attached() && renderer() && !useFallbackContent())
// Update the widget the next time we attach (detaching destroys the plugin).
setNeedsWidgetUpdate(true);
- HTMLPlugInElement::detach();
+ HTMLPlugInElement::detach(context);
}
void HTMLPlugInImageElement::updateWidgetIfNecessary()
« no previous file with comments | « Source/core/html/HTMLPlugInImageElement.h ('k') | Source/core/html/HTMLProgressElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698