Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: Source/core/html/HTMLOptionElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLOptionElement.h ('k') | Source/core/html/HTMLPlugInElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLOptionElement.cpp
diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp
index 54940a9d2af44b0c896db9175862b72c12a58155..d549848b91247cb22cc53c634d5a56f5cf34c207 100644
--- a/Source/core/html/HTMLOptionElement.cpp
+++ b/Source/core/html/HTMLOptionElement.cpp
@@ -87,9 +87,9 @@ PassRefPtr<HTMLOptionElement> HTMLOptionElement::createForJSConstructor(Document
return element.release();
}
-void HTMLOptionElement::attach()
+void HTMLOptionElement::attach(const AttachContext& context)
{
- HTMLElement::attach();
+ HTMLElement::attach(context);
// If after attaching nothing called styleForRenderer() on this node we
// manually cache the value. This happens if our parent doesn't have a
// renderer like <optgroup> or if it doesn't allow children like <select>.
@@ -97,10 +97,10 @@ void HTMLOptionElement::attach()
updateNonRenderStyle();
}
-void HTMLOptionElement::detach()
+void HTMLOptionElement::detach(const AttachContext& context)
{
m_style.clear();
- HTMLElement::detach();
+ HTMLElement::detach(context);
}
bool HTMLOptionElement::supportsFocus() const
« no previous file with comments | « Source/core/html/HTMLOptionElement.h ('k') | Source/core/html/HTMLPlugInElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698