Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Source/core/svg/SVGImageElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGImageElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Rob Buis <buis@kde.org>
4 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org> 4 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 RenderObject* SVGImageElement::createRenderer(RenderArena* arena, RenderStyle*) 190 RenderObject* SVGImageElement::createRenderer(RenderArena* arena, RenderStyle*)
191 { 191 {
192 return new (arena) RenderSVGImage(this); 192 return new (arena) RenderSVGImage(this);
193 } 193 }
194 194
195 bool SVGImageElement::haveLoadedRequiredResources() 195 bool SVGImageElement::haveLoadedRequiredResources()
196 { 196 {
197 return !externalResourcesRequiredBaseValue() || !m_imageLoader.hasPendingAct ivity(); 197 return !externalResourcesRequiredBaseValue() || !m_imageLoader.hasPendingAct ivity();
198 } 198 }
199 199
200 void SVGImageElement::attach() 200 void SVGImageElement::attach(const AttachContext& context)
201 { 201 {
202 SVGStyledTransformableElement::attach(); 202 SVGStyledTransformableElement::attach(context);
203 203
204 if (RenderSVGImage* imageObj = toRenderSVGImage(renderer())) { 204 if (RenderSVGImage* imageObj = toRenderSVGImage(renderer())) {
205 if (imageObj->imageResource()->hasImage()) 205 if (imageObj->imageResource()->hasImage())
206 return; 206 return;
207 207
208 imageObj->imageResource()->setCachedImage(m_imageLoader.image()); 208 imageObj->imageResource()->setCachedImage(m_imageLoader.image());
209 } 209 }
210 } 210 }
211 211
212 Node::InsertionNotificationRequest SVGImageElement::insertedInto(ContainerNode* rootParent) 212 Node::InsertionNotificationRequest SVGImageElement::insertedInto(ContainerNode* rootParent)
(...skipping 19 matching lines...) Expand all
232 addSubresourceURL(urls, document()->completeURL(href())); 232 addSubresourceURL(urls, document()->completeURL(href()));
233 } 233 }
234 234
235 void SVGImageElement::didMoveToNewDocument(Document* oldDocument) 235 void SVGImageElement::didMoveToNewDocument(Document* oldDocument)
236 { 236 {
237 m_imageLoader.elementDidMoveToNewDocument(); 237 m_imageLoader.elementDidMoveToNewDocument();
238 SVGStyledTransformableElement::didMoveToNewDocument(oldDocument); 238 SVGStyledTransformableElement::didMoveToNewDocument(oldDocument);
239 } 239 }
240 240
241 } 241 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGImageElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698