Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: Source/core/html/shadow/SpinButtonElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 } 54 }
55 55
56 PassRefPtr<SpinButtonElement> SpinButtonElement::create(Document* document, Spin ButtonOwner& spinButtonOwner) 56 PassRefPtr<SpinButtonElement> SpinButtonElement::create(Document* document, Spin ButtonOwner& spinButtonOwner)
57 { 57 {
58 RefPtr<SpinButtonElement> element = adoptRef(new SpinButtonElement(document, spinButtonOwner)); 58 RefPtr<SpinButtonElement> element = adoptRef(new SpinButtonElement(document, spinButtonOwner));
59 element->setPseudo(AtomicString("-webkit-inner-spin-button", AtomicString::C onstructFromLiteral)); 59 element->setPseudo(AtomicString("-webkit-inner-spin-button", AtomicString::C onstructFromLiteral));
60 element->setAttribute(idAttr, ShadowElementNames::spinButton()); 60 element->setAttribute(idAttr, ShadowElementNames::spinButton());
61 return element.release(); 61 return element.release();
62 } 62 }
63 63
64 void SpinButtonElement::detach() 64 void SpinButtonElement::detach(const AttachContext& context)
65 { 65 {
66 releaseCapture(); 66 releaseCapture();
67 HTMLDivElement::detach(); 67 HTMLDivElement::detach(context);
68 } 68 }
69 69
70 void SpinButtonElement::defaultEventHandler(Event* event) 70 void SpinButtonElement::defaultEventHandler(Event* event)
71 { 71 {
72 if (!event->isMouseEvent()) { 72 if (!event->isMouseEvent()) {
73 if (!event->defaultHandled()) 73 if (!event->defaultHandled())
74 HTMLDivElement::defaultEventHandler(event); 74 HTMLDivElement::defaultEventHandler(event);
75 return; 75 return;
76 } 76 }
77 77
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 m_upDownState = Indeterminate; 249 m_upDownState = Indeterminate;
250 HTMLDivElement::setHovered(flag); 250 HTMLDivElement::setHovered(flag);
251 } 251 }
252 252
253 bool SpinButtonElement::shouldRespondToMouseEvents() 253 bool SpinButtonElement::shouldRespondToMouseEvents()
254 { 254 {
255 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents(); 255 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents();
256 } 256 }
257 257
258 } 258 }
OLDNEW
« no previous file with comments | « Source/core/html/shadow/SpinButtonElement.h ('k') | Source/core/html/shadow/TextControlInnerElements.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698