Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: Source/core/html/shadow/PickerIndicatorElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 m_chooser = document()->page()->chrome().openDateTimeChooser(this, parameter s); 119 m_chooser = document()->page()->chrome().openDateTimeChooser(this, parameter s);
120 } 120 }
121 121
122 void PickerIndicatorElement::closePopup() 122 void PickerIndicatorElement::closePopup()
123 { 123 {
124 if (!m_chooser) 124 if (!m_chooser)
125 return; 125 return;
126 m_chooser->endChooser(); 126 m_chooser->endChooser();
127 } 127 }
128 128
129 void PickerIndicatorElement::detach() 129 void PickerIndicatorElement::detach(const AttachContext& context)
130 { 130 {
131 closePopup(); 131 closePopup();
132 HTMLDivElement::detach(); 132 HTMLDivElement::detach(context);
133 } 133 }
134 134
135 bool PickerIndicatorElement::isPickerIndicatorElement() const 135 bool PickerIndicatorElement::isPickerIndicatorElement() const
136 { 136 {
137 return true; 137 return true;
138 } 138 }
139 139
140 } 140 }
141 141
142 #endif 142 #endif
OLDNEW
« no previous file with comments | « Source/core/html/shadow/PickerIndicatorElement.h ('k') | Source/core/html/shadow/SliderThumbElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698