Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: Source/core/html/HTMLVideoElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLVideoElement.h ('k') | Source/core/html/PluginDocument.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 bool HTMLVideoElement::rendererIsNeeded(const NodeRenderingContext& context) 62 bool HTMLVideoElement::rendererIsNeeded(const NodeRenderingContext& context)
63 { 63 {
64 return HTMLElement::rendererIsNeeded(context); 64 return HTMLElement::rendererIsNeeded(context);
65 } 65 }
66 66
67 RenderObject* HTMLVideoElement::createRenderer(RenderArena* arena, RenderStyle*) 67 RenderObject* HTMLVideoElement::createRenderer(RenderArena* arena, RenderStyle*)
68 { 68 {
69 return new (arena) RenderVideo(this); 69 return new (arena) RenderVideo(this);
70 } 70 }
71 71
72 void HTMLVideoElement::attach() 72 void HTMLVideoElement::attach(const AttachContext& context)
73 { 73 {
74 HTMLMediaElement::attach(); 74 HTMLMediaElement::attach(context);
75 75
76 updateDisplayState(); 76 updateDisplayState();
77 if (shouldDisplayPosterImage()) { 77 if (shouldDisplayPosterImage()) {
78 if (!m_imageLoader) 78 if (!m_imageLoader)
79 m_imageLoader = adoptPtr(new HTMLImageLoader(this)); 79 m_imageLoader = adoptPtr(new HTMLImageLoader(this));
80 m_imageLoader->updateFromElement(); 80 m_imageLoader->updateFromElement();
81 if (renderer()) 81 if (renderer())
82 toRenderImage(renderer())->imageResource()->setCachedImage(m_imageLo ader->image()); 82 toRenderImage(renderer())->imageResource()->setCachedImage(m_imageLo ader->image());
83 } 83 }
84 } 84 }
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 276
277 KURL HTMLVideoElement::posterImageURL() const 277 KURL HTMLVideoElement::posterImageURL() const
278 { 278 {
279 String url = stripLeadingAndTrailingHTMLSpaces(imageSourceURL()); 279 String url = stripLeadingAndTrailingHTMLSpaces(imageSourceURL());
280 if (url.isEmpty()) 280 if (url.isEmpty())
281 return KURL(); 281 return KURL();
282 return document()->completeURL(url); 282 return document()->completeURL(url);
283 } 283 }
284 284
285 } 285 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLVideoElement.h ('k') | Source/core/html/PluginDocument.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698