Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLLIElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 803 matching lines...) Expand 10 before | Expand all | Expand 10 after
814 bool HTMLInputElement::rendererIsNeeded(const NodeRenderingContext& context) 814 bool HTMLInputElement::rendererIsNeeded(const NodeRenderingContext& context)
815 { 815 {
816 return m_inputType->rendererIsNeeded() && HTMLTextFormControlElement::render erIsNeeded(context); 816 return m_inputType->rendererIsNeeded() && HTMLTextFormControlElement::render erIsNeeded(context);
817 } 817 }
818 818
819 RenderObject* HTMLInputElement::createRenderer(RenderArena* arena, RenderStyle* style) 819 RenderObject* HTMLInputElement::createRenderer(RenderArena* arena, RenderStyle* style)
820 { 820 {
821 return m_inputType->createRenderer(arena, style); 821 return m_inputType->createRenderer(arena, style);
822 } 822 }
823 823
824 void HTMLInputElement::attach() 824 void HTMLInputElement::attach(const AttachContext& context)
825 { 825 {
826 PostAttachCallbackDisabler disabler(this); 826 PostAttachCallbackDisabler disabler(this);
827 827
828 if (!m_hasType) 828 if (!m_hasType)
829 updateType(); 829 updateType();
830 830
831 HTMLTextFormControlElement::attach(); 831 HTMLTextFormControlElement::attach(context);
832 832
833 m_inputType->attach(); 833 m_inputType->attach();
834 834
835 if (document()->focusedNode() == this) 835 if (document()->focusedNode() == this)
836 document()->updateFocusAppearanceSoon(true /* restore selection */); 836 document()->updateFocusAppearanceSoon(true /* restore selection */);
837 } 837 }
838 838
839 void HTMLInputElement::detach() 839 void HTMLInputElement::detach(const AttachContext& context)
840 { 840 {
841 HTMLTextFormControlElement::detach(); 841 HTMLTextFormControlElement::detach(context);
842 setFormControlValueMatchesRenderer(false); 842 setFormControlValueMatchesRenderer(false);
843 m_inputType->detach(); 843 m_inputType->detach();
844 } 844 }
845 845
846 String HTMLInputElement::altText() const 846 String HTMLInputElement::altText() const
847 { 847 {
848 // http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen 848 // http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen
849 // also heavily discussed by Hixie on bugzilla 849 // also heavily discussed by Hixie on bugzilla
850 // note this is intentionally different to HTMLImageElement::altText() 850 // note this is intentionally different to HTMLImageElement::altText()
851 String alt = fastGetAttribute(altAttr); 851 String alt = fastGetAttribute(altAttr);
(...skipping 1074 matching lines...) Expand 10 before | Expand all | Expand 10 after
1926 } 1926 }
1927 1927
1928 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1928 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1929 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1929 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1930 { 1930 {
1931 return m_inputType->customStyleForRenderer(originalStyleForRenderer()); 1931 return m_inputType->customStyleForRenderer(originalStyleForRenderer());
1932 } 1932 }
1933 #endif 1933 #endif
1934 1934
1935 } // namespace 1935 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLLIElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698