Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: Source/core/html/HTMLImageElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLImageElement.h ('k') | Source/core/html/HTMLInputElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserv ed.
5 * Copyright (C) 2010 Google Inc. All rights reserved. 5 * Copyright (C) 2010 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 } 149 }
150 150
151 bool HTMLImageElement::canStartSelection() const 151 bool HTMLImageElement::canStartSelection() const
152 { 152 {
153 if (shadow()) 153 if (shadow())
154 return HTMLElement::canStartSelection(); 154 return HTMLElement::canStartSelection();
155 155
156 return false; 156 return false;
157 } 157 }
158 158
159 void HTMLImageElement::attach() 159 void HTMLImageElement::attach(const AttachContext& context)
160 { 160 {
161 HTMLElement::attach(); 161 HTMLElement::attach(context);
162 162
163 if (renderer() && renderer()->isImage() && !m_imageLoader.hasPendingBeforeLo adEvent()) { 163 if (renderer() && renderer()->isImage() && !m_imageLoader.hasPendingBeforeLo adEvent()) {
164 RenderImage* renderImage = toRenderImage(renderer()); 164 RenderImage* renderImage = toRenderImage(renderer());
165 RenderImageResource* renderImageResource = renderImage->imageResource(); 165 RenderImageResource* renderImageResource = renderImage->imageResource();
166 if (renderImageResource->hasImage()) 166 if (renderImageResource->hasImage())
167 return; 167 return;
168 renderImageResource->setCachedImage(m_imageLoader.image()); 168 renderImageResource->setCachedImage(m_imageLoader.image());
169 169
170 // If we have no image at all because we have no src attribute, set 170 // If we have no image at all because we have no src attribute, set
171 // image height and width for the alt text instead. 171 // image height and width for the alt text instead.
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 363
364 void HTMLImageElement::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) con st 364 void HTMLImageElement::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) con st
365 { 365 {
366 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); 366 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);
367 HTMLElement::reportMemoryUsage(memoryObjectInfo); 367 HTMLElement::reportMemoryUsage(memoryObjectInfo);
368 info.addMember(m_imageLoader, "imageLoader"); 368 info.addMember(m_imageLoader, "imageLoader");
369 info.addMember(m_form, "form"); 369 info.addMember(m_form, "form");
370 } 370 }
371 371
372 } 372 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLImageElement.h ('k') | Source/core/html/HTMLInputElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698