Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLFrameElementBase.h ('k') | Source/core/html/HTMLFrameSetElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann (hausmann@kde.org) 4 * (C) 2000 Simon Hausmann (hausmann@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 // during attribute parsing *before* the normal parser machinery would 154 // during attribute parsing *before* the normal parser machinery would
155 // attach the element. To support this, we lazyAttach here, but only 155 // attach the element. To support this, we lazyAttach here, but only
156 // if we don't already have a renderer (if we're inserted 156 // if we don't already have a renderer (if we're inserted
157 // as part of a DocumentFragment, insertedInto from an earlier element 157 // as part of a DocumentFragment, insertedInto from an earlier element
158 // could have forced a style resolve and already attached us). 158 // could have forced a style resolve and already attached us).
159 if (!renderer()) 159 if (!renderer())
160 lazyAttach(DoNotSetAttached); 160 lazyAttach(DoNotSetAttached);
161 setNameAndOpenURL(); 161 setNameAndOpenURL();
162 } 162 }
163 163
164 void HTMLFrameElementBase::attach() 164 void HTMLFrameElementBase::attach(const AttachContext& context)
165 { 165 {
166 HTMLFrameOwnerElement::attach(); 166 HTMLFrameOwnerElement::attach(context);
167 167
168 if (RenderPart* part = renderPart()) { 168 if (RenderPart* part = renderPart()) {
169 if (Frame* frame = contentFrame()) 169 if (Frame* frame = contentFrame())
170 part->setWidget(frame->view()); 170 part->setWidget(frame->view());
171 } 171 }
172 } 172 }
173 173
174 KURL HTMLFrameElementBase::location() const 174 KURL HTMLFrameElementBase::location() const
175 { 175 {
176 if (fastHasAttribute(srcdocAttr)) 176 if (fastHasAttribute(srcdocAttr))
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 222
223 int HTMLFrameElementBase::height() 223 int HTMLFrameElementBase::height()
224 { 224 {
225 document()->updateLayoutIgnorePendingStylesheets(); 225 document()->updateLayoutIgnorePendingStylesheets();
226 if (!renderBox()) 226 if (!renderBox())
227 return 0; 227 return 0;
228 return renderBox()->height(); 228 return renderBox()->height();
229 } 229 }
230 230
231 } // namespace WebCore 231 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFrameElementBase.h ('k') | Source/core/html/HTMLFrameSetElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698