Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlElement.h ('k') | Source/core/html/HTMLFrameElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 196
197 return false; 197 return false;
198 } 198 }
199 199
200 static void focusPostAttach(Node* element) 200 static void focusPostAttach(Node* element)
201 { 201 {
202 toElement(element)->focus(); 202 toElement(element)->focus();
203 element->deref(); 203 element->deref();
204 } 204 }
205 205
206 void HTMLFormControlElement::attach() 206 void HTMLFormControlElement::attach(const AttachContext& context)
207 { 207 {
208 PostAttachCallbackDisabler disabler(this); 208 PostAttachCallbackDisabler disabler(this);
209 209
210 HTMLElement::attach(); 210 HTMLElement::attach(context);
211 211
212 // The call to updateFromElement() needs to go after the call through 212 // The call to updateFromElement() needs to go after the call through
213 // to the base class's attach() because that can sometimes do a close 213 // to the base class's attach() because that can sometimes do a close
214 // on the renderer. 214 // on the renderer.
215 if (renderer()) 215 if (renderer())
216 renderer()->updateFromElement(); 216 renderer()->updateFromElement();
217 217
218 if (shouldAutofocus(this)) { 218 if (shouldAutofocus(this)) {
219 setAutofocused(); 219 setAutofocused();
220 ref(); 220 ref();
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 } 473 }
474 474
475 void HTMLFormControlElement::reportMemoryUsage(MemoryObjectInfo* memoryObjectInf o) const 475 void HTMLFormControlElement::reportMemoryUsage(MemoryObjectInfo* memoryObjectInf o) const
476 { 476 {
477 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); 477 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);
478 LabelableElement::reportMemoryUsage(memoryObjectInfo); 478 LabelableElement::reportMemoryUsage(memoryObjectInfo);
479 info.addMember(m_validationMessage, "validationMessage"); 479 info.addMember(m_validationMessage, "validationMessage");
480 } 480 }
481 481
482 } // namespace Webcore 482 } // namespace Webcore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFormControlElement.h ('k') | Source/core/html/HTMLFrameElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698